Fixed #1097: [Ag20] Style broken on material and bootstrap classes #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lasses (Replaced mr- into me-, removed mr-lg, mr-sm)
…lasses (Replaced ml- into ms-, removed ml-lg, ml-md, ml-sm)
…lasses (Fixed styling issues on the top navbar)
…lasses (Fixed Card component, font and login page)
…lasses (Replaced pr- into pe-, pl- into ps-)
…lasses (Fixed Dashboard page)
…lasses (Fixed Score improvement dialog)
…lasses (Fixed Network activity page)
…lasses (Fixed Assets pages excluding Registries page)
…lasses (Fixed Policy pages)
…lasses (Fixed Security risks pages)
…lasses (Fixed Notifications pages)
…lasses (Fixed all the setting pages)
…lasses (Fixed User profile page)
Contributor
|
LGTM. There is a lot of alignment / spacing issues we will need to fine tune still. Apart from that there are a few functionality bugs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits are separated for different fixed location. It will be easier for reviewing.
The final layout details could be different from v5.4.8.
What do should be check is the layout broken or alignment issue.